8000 #145 handle nil pointer dereference for tracked record by alksmt · Pull Request #150 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]
Skip to content
1 8000

#145 handle nil pointer dereference for tracked record - #150

Merged
dominikbraun merged 2 commits into
dominikbraun:mainfrom
alksmt:#145-fixing-tracked-record-panic
Jul 5, 2021
Merged

#145 handle nil pointer dereference for tracked record#150
dominikbraun merged 2 commits into
dominikbraun:mainfrom
alksmt:#145-fixing-tracked-record-panic

Conversation

@alksmt
@alksmt alksmt commented Jun 30, 2021
Copy link
Copy Markdown
Contributor

PR for #145

Changes:

  • Fixing issue with nil pointer dereference during collides check against tracked record
  • Simplified collides check conditions (here's a good reference for it: Date ranges overlap check)
  • Added missing test cases for complete records and new ones for records that are being tracked

alksmt added 2 commits June 30, 2021 13:52
aligator
aligator approved these changes Jun 30, 2021
View reviewed changes
@aligator aligator left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikbraun dominikbraun linked an issue Jul 4, 2021 that may be closed by this pull request
timetrace create record panics because of nil pointer dereference #145
Closed
dominikbraun
dominikbraun approved these changes Jul 5, 2021
View reviewed changes
@dominikbraun dominikbraun left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@dominikbraun
dominikbraun merged commit 7f2ae91 into dominikbraun:main Jul 5, 2021
@dominikbraun
dominikbraun commented Jul 6, 2021
Copy link
Copy Markdown
Owner

This PR is included in timetrace v0.11.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aligator aligator aligator approved these changes
@dominikbraun dominikbraun dominikbraun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

timetrace create record panics because of nil pointer dereference

3 participants

@alksmt @dominikbraun @aligator
0