8000 #139 Added a separate method for duration calculation by alksmt · Pull Request #146 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]

Skip to content

#139 Added a separate method for duration calculation - #146

Merged
dominikbraun merged 4 commits into
dominikbraun:mainfrom
alksmt:#139-duration-calculation-method
Jul 13, 2021
Merged

dominikbraun merged 4 commits into
dominikbraun:mainfrom
alksmt:#139-duration-calculation-method

Conversation

@alksmt
@alksmt alksmt commented Jun 29, 2021
Copy link
Copy Markdown
Contributor

PR for #139

Moving duration calculation to a separate Duration method, including cases when a record is still being tracked.

@dominikbraun
dominikbraun self-requested a review June 29, 2021 15:12
@dominikbraun dominikbraun left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@dominikbraun
Copy link
Copy Markdown
Owner

@alksmt A PR has been merged that still contained two record.End.Sub(record.Start) calls. Would you like to replace them as well before this PR gets merged or should I do this myself? 😄

@dominikbraun dominikbraun added this to the timetrace v0.12.0 milestone Jul 10, 2021
@alksmt
alksmt commented Jul 13, 2021
Copy link
Copy Markdown
Contributor Author

@dominikbraun replaced this entries and found another one for status command, PR is up to date with main branch

@dominikbraun
Copy link
Copy Markdown
Owner

@alksmt Thanks!

@dominikbraun
dominikbraun merged commit 095756f into dominikbraun:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0