8000 [Patch] Remove seconds from Time Formatter by dhanushsr · Pull Request #113 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]
Skip to content

[Patch] Remove seconds from Time Formatter - #113

Merged
dominikbraun merged 2 commits into
dominikbraun:mainfrom
dhanushsr:fix/remove_seconds_in_time_format
Jun 12, 2021
Merged

[Patch] Remove seconds from Time Formatter#113
dominikbraun merged 2 commits into
dominikbraun:mainfrom
dhanushsr:fix/remove_seconds_in_time_format

Conversation

@dhanushsr
@dhanushsr dhanushsr commented Jun 9, 2021
Copy link
Copy Markdown
Contributor

In the time formatter package, if hours and minutes are 0 then seconds will be considered. As seconds is not handled in users perspective, seconds need not be considered.

@dominikbraun
dominikbraun self-requested a review June 12, 2021 07:44
dominikbraun
dominikbraun approved these changes Jun 12, 2021
View reviewed changes
@dominikbraun dominikbraun left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@dominikbraun dominikbraun linked an issue Jun 12, 2021 that may be closed by this pull request
timetrace status: Display break time without seconds #105
Closed
@dominikbraun
dominikbraun merged commit c6da785 into dominikbraun:main Jun 12, 2021
@dhanushsr
dhanushsr deleted the fix/remove_seconds_in_time_format branch July 7, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominikbraun dominikbraun dominikbraun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

timetrace status: Display break time without seconds

2 participants

@dhanushsr @dominikbraun
0