8000 Don't return an error if there are no records yet by dominikbraun · Pull Request #103 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]

Skip to content

Don't return an error if there are no records yet - #103

Merged
dominikbraun merged 2 commits into
mainfrom
#102-dont-return-an-error-if-there-are-no-records-yet
Jun 4, 2021
Merged

dominikbraun merged 2 commits into
mainfrom
#102-dont-return-an-error-if-there-are-no-records-yet

Conversation

@dominikbraun
Copy link
Copy Markdown
Owner

No description provided.

@dominikbraun
Copy link
Copy Markdown
Owner Author

Update: Instead if ignoring ErrAllDirectoriesEmpty in general, only Start ignores the error as @KonstantinGasser mentioned in #102.

Also, LoadLatestRecord now returns a potential ErrAllDirectories directly instead of an ErrTrackingNotStarted, because this error is without the scope of a function loading a record.

Comment thread core/timetrace.go Resolved
@joshuaherrera joshuaherrera left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes and it works.

@dominikbraun
Copy link
Copy Markdown
Owner Author

Thanks @joshuaherrera and @KonstantinGasser!

@dominikbraun
dominikbraun merged commit 644237d into main Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0