Repository navigation
98 break - #100
Merged
Merged
98 break#100
Conversation
dominikbraun
self-requested a review
June 1, 2021 09:52
rknizzle
commented
Jun 1, 2021
dominikbraun
requested changes
Jun 2, 2021
Owner
There was a problem hiding this comment.
Looks pretty good to me, I just requested a minor change.
added 5 commits
June 2, 2021 22:11
- It uses the less argument to RecordFilepaths to do the sorting
- I realized that fs.RecordFilepaths already has a mechanism for sorting the record filenames by start time so I think its better to take advantage of that and use loadAllRecordsSortedAscending instead of sorting in breakTime()
dominikbraun
self-requested a review
June 3, 2021 06:51
dominikbraun
approved these changes
Jun 6, 2021
Owner
There was a problem hiding this comment.
LGTM, thanks for implementing this! 👍
Owner
|
This PR is contained in release 0.8.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds break time for the day when you run the status command.
The break time is calculated as the time between all records
Resolves #98