8000 added method to check if parent project exists for module by FelixTheodor · Pull Request #80 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]

Skip to content

added method to check if parent project exists for module - #80

Merged
dominikbraun merged 3 commits into
dominikbraun:mainfrom
FelixTheodor:dont_create_nonparents
May 30, 2021
Merged

dominikbraun merged 3 commits into
dominikbraun:mainfrom
FelixTheodor:dont_create_nonparents

Conversation

@FelixTheodor
Copy link
Copy Markdown
Contributor

closes #72

i added a method to check if the parent of a module exists before creating it.
the create-command now returns an error if it does not exist.

@dominikbraun dominikbraun left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion 😄

Comment thread core/project.go Resolved
Comment thread core/project.go Resolved
@FelixTheodor
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback, added the changes in a new commit :)

@dominikbraun dominikbraun left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@dominikbraun
dominikbraun merged commit 530a420 into dominikbraun:main May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent users from creating modules for non-existent projects

2 participants

0