8000 Display project modules by FelixTheodor · Pull Request #70 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]

Skip to content

Display project modules - #70

Merged
dominikbraun merged 4 commits into
dominikbraun:mainfrom
FelixTheodor:main
May 30, 2021
Merged

dominikbraun merged 4 commits into
dominikbraun:mainfrom
FelixTheodor:main

Conversation

@FelixTheodor
Copy link
Copy Markdown
Contributor

closes #60

I added a new method ListProjectModules that uses loadProjectModules to create a string with all the modules of a project.
They will be printed out on timetrace list projects

But there is a problem with this solution: Modules, that are created for a non-existent parent-project are not listed at all. Therefore, I would propose that we prevent users from creating modules for non-existent projects.

@dominikbraun
dominikbraun self-requested a review May 23, 2021 14:02
@dominikbraun
Copy link
Copy Markdown
Owner

Therefore, I would propose that we prevent users from creating modules for non-existent projects.

Absolutely, we'll need to open an issue for that.

@dominikbraun dominikbraun left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@dominikbraun
dominikbraun merged commit 6f81d6d into dominikbraun:main May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timetrace list projects: Display project modules

2 participants

0