8000 Handle editing of incomplete record by adzo261 · Pull Request #69 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]

Skip to content

Handle editing of incomplete record - #69

Merged
dominikbraun merged 3 commits into
dominikbraun:mainfrom
adzo261:handle-incomplete-record-edit
May 26, 2021
Merged

dominikbraun merged 3 commits into
dominikbraun:mainfrom
adzo261:handle-incomplete-record-edit

Conversation

@adzo261
@adzo261 adzo261 commented May 23, 2021 •
Copy link
Copy Markdown
Contributor

closes #68

  • Throw record is still in progress error on trying to edit incomplete record
  • Refactor common logic into editRecord method

@dominikbraun
dominikbraun self-requested a review May 23, 2021 13:36
Comment thread core/record.go Resolved
@dominikbraun dominikbraun left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@dominikbraun
dominikbraun merged commit 748db2e into dominikbraun:main May 26, 2021
@dominikbraun
Copy link
Copy Markdown
Owner

This PR is included in release v0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timetrace edit record panics when there is no end time of the latest record

2 participants

0