Repository navigation
implement timetrace edit record command - #51
Merged
Merged
Conversation
dominikbraun
self-requested a review
May 20, 2021 12:12
dominikbraun
requested changes
May 21, 2021
Owner
There was a problem hiding this comment.
Nice work, thanks! 👍 I just requested a minor change.
Owner
|
This PR is included in release v0.6.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented the edit record command as mentioned here: #19
As of now, there is no check if the end time contradicts with the start time of another record (still an open question), but the command returns an error if the new end time is before the start time of the record.