8000 #28 Proposed changes of adding Record Key in `list` using `Formatter` by aaronsheah · Pull Request #44 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]

Skip to content

#28 Proposed changes of adding Record Key in list using Formatter - #44

Merged
dominikbraun merged 3 commits into
dominikbraun:mainfrom
aaronsheah:28-proposal
May 22, 2021
Merged

dominikbraun merged 3 commits into
dominikbraun:mainfrom
aaronsheah:28-proposal

Conversation

@aaronsheah
@aaronsheah aaronsheah commented May 19, 2021 •
Copy link
Copy Markdown
Contributor

12 Hour

Screenshot 2021-05-19 at 23 40 32

24 Hour

Screenshot 2021-05-19 at 23 42 11

resolves #28

@aaronsheah aaronsheah mentioned this pull request May 19, 2021
@aaronsheah aaronsheah changed the title #28 Proposed changes using Formatter #28 Proposed changes of adding Record Key in list using Formatter May 19, 2021
@dominikbraun
dominikbraun self-requested a review May 19, 2021 20:04
@dominikbraun dominikbraun left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aligator PTAL

Comment thread core/formatter.go Resolved
Comment thread core/formatter.go Resolved
@aaronsheah
Copy link
Copy Markdown
Contributor Author

Thanks @dominikbraun silly mistakes, must have still haven't woken up then 😆

@aaronsheah
aaronsheah requested a review from dominikbraun May 19, 2021 22:43
@dominikbraun
Copy link
Copy Markdown
Owner

@aaronsheah I think you need to use the new Formatter for get and delete as well - then this PR can be merged 😄

@aligator
Copy link
Copy Markdown
Collaborator

@aligator PTAL

Looks good to me :-)

@aaronsheah
Copy link
Copy Markdown
Contributor Author

@dominikbraun updated :)

@dominikbraun dominikbraun left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dominikbraun
dominikbraun merged commit f251189 into dominikbraun:main May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timetrace list records should include "record key"

3 participants

0