8000 Email field mapping · Pull Request #38 · dominik-th/matomo-plugin-LoginOIDC · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Nov 11, 2026. It is now read-only.

Email field mapping - #38

#38
Open
ghost wants to merge 6 commits into
4.x-devfrom
unknown repository
Open

ghost wants to merge 6 commits into
4.x-devfrom
unknown repository

Conversation

@ghost
@ghost ghost commented Dec 31, 2020
Copy link
Copy Markdown

Email field mapping

leftmostlane added 6 commits December 31, 2020 10:36
table needs to be the same character set as Matomo.  Matomo is utf8.  Some databases do not have utf8 set as the default.
@dominik-th
Copy link
Copy Markdown
Owner

Thanks for your PR!
Can you explain what you are trying to achieve here?

$emailId = $settings->emailId->getValue();
$this->signupUser($settings, $providerUserId, $emailId);

How do you want to sign up a user with an email address which is stored in the system settings?

@ghost
ghost commented Jan 1, 2021
Copy link
Copy Markdown
Author

If the key for email in the JSON is something like "corp_email" instead of "email" then LoginOIDC fails because "email" is null. This code permits us to choose the name of the "key" in the returned JSON.

Another idea is to reuse providerId:
$this->signupUser($settings, $providerUserId, $emailId);

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0