8000 Create Matomo users for unknown OIDC users by nightkr · Pull Request #8 · dominik-th/matomo-plugin-LoginOIDC · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Nov 11, 2026. It is now read-only.

Create Matomo users for unknown OIDC users - #8

Merged
dominik-th merged 2 commits into
dominik-th:masterfrom
Appva:feature/4-user-signup
Oct 10, 2019
Merged

dominik-th merged 2 commits into
dominik-th:masterfrom
Appva:feature/4-user-signup

Conversation

@nightkr
@nightkr nightkr commented Oct 8, 2019
Copy link
Copy Markdown
Contributor

This is hidden behind a flag, and is currently only tested against Azure AD.
These users do not currently get access to any sites.

Fixes #4.

This is hidden behind a flag, and is currently only tested against Azure AD.
These users do not currently get access to any sites.

Fixes dominik-th#4.
@dominik-th dominik-th left a comment •
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution.

Please fix the issue I commented below, otherwise it works great!

Comment thread Controller.php
if (Piwik::isUserIsAnonymous()) {
throw new Exception(Piwik::translate("LoginOIDC_ExceptionUserNotFound"));
if ($settings->allowSignup->getValue()) {
$matomoUserLogin = $result->email;
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$result->email might be null if requested without the 'email' scope.
There should be a check if email is set and an appropriate error message if not

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, will sort that out.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now, but I haven't been able to test it.

@dominik-th
dominik-th merged commit 9e12397 into dominik-th:master Oct 10, 2019
@dominik-th
Copy link
Copy Markdown
Owner

Looks good to me now, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fails to register new user

2 participants

0