This repository was archived by the owner on Nov 11, 2026. It is now read-only.
Repository navigation
Create Matomo users for unknown OIDC users - #8
Merged
Merged
Conversation
This is hidden behind a flag, and is currently only tested against Azure AD. These users do not currently get access to any sites. Fixes dominik-th#4.
dominik-th
suggested changes
Oct 8, 2019
| if (Piwik::isUserIsAnonymous()) { | ||
| throw new Exception(Piwik::translate("LoginOIDC_ExceptionUserNotFound")); | ||
| if ($settings->allowSignup->getValue()) { | ||
| $matomoUserLogin = $result->email; |
Owner
There was a problem hiding this comment.
$result->email might be null if requested without the 'email' scope.
There should be a check if email is set and an appropriate error message if not
Contributor
Author
There was a problem hiding this comment.
Good point, will sort that out.
Contributor
Author
There was a problem hiding this comment.
Should be fixed now, but I haven't been able to test it.
Owner
|
Looks good to me now, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is hidden behind a flag, and is currently only tested against Azure AD.
These users do not currently get access to any sites.
Fixes #4.