Repository navigation
fix(spec-sync): pin snapshots to the selected commit - #324
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec sync selected a commit for its baseline but fetched mutable directory inventories and download URLs. An upstream advance could therefore publish different or mixed file versions under the earlier commit marker. All root/v1/v2 inventory requests now use the selected full commit SHA as their
ref, and invalid selection values stop before inventory or publication. The returned commit-specific download URLs and existing baseline/PR metadata describe one snapshot.The actual-workflow fixture executes the complete workflow from a private script file and covers a stable upstream and advances after commit selection, after inventory selection and between file downloads. Each revision has changed common files and distinct added/deleted files in all three directories. It verifies all API refs, six downloaded files and their contents, the baseline and PR metadata. Invalid commit values must leave the baseline and existing proposal intact without inventory or publication calls. Existing download-failure, pruning and line-ending coverage is retained.
Validation: all nine new cases failed before the fix while the 23 download-admission controls passed; all now pass. Formatting, module tidiness, build, vet, lint, ordinary/race suites, focused workflow tests and parsed workflow/shell/Python checks passed. Read-only queries using the real directory API operation verified commit-specific URLs for all 320 checked-in schema files. Independent review found no actionable issues. No live spec-sync workflow was run.
Closes #249