Repository navigation
fix(spec-sync): reject failed schema downloads - #323
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec sync could treat HTTP error bodies and malformed successful responses as schema changes, then advance the baseline and replace an existing sync proposal. Downloads now require completed transfers with a final HTTP 2xx status. The entire temporary candidate is checked as JSON before comparison, tracked snapshot replacement, baseline advancement or any branch/pull-request publication and cleanup.
The regression harness executes the actual workflow with real curl against a local HTTP server and inert publication operations. The extractor accepts both LF and CRLF workflow checkouts. Its 23 download cases cover valid downloads and redirects, HTTP failures, malformed/empty/multiple-document/non-finite JSON, truncated transfers and inventory errors across root/v1/v2. Failures preserve the existing snapshot, baseline and proposal and remove the temporary candidate. Spec-sync and threat-model documentation describe this admission boundary and its limits. Immutable snapshot pinning remains the separate #249 unit.
Validation: 15 regression cases failed before the fix; all 23 now pass. Formatting, module tidiness, build, vet, lint, ordinary and race suites, focused workflow/pruning tests, parsed workflow/shell/Python validation and validation of the current checked-in schemas passed. Independent patch review found no actionable issues. No live spec-sync workflow was run.
Closes #248