Repository navigation
fix(protocol)!: preserve int64 RPC error codes - #319
Merged
Merged
Conversation
Use the schema-defined signed 64-bit code throughout public errors, incoming parsing and outgoing generated/callback replies. Execute focused 32-bit coverage in CI. BREAKING CHANGE: Error.Code and RPCError.Code() now use int64 instead of int.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a69f8de430
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 32-bit build rejected valid JSON-RPC error codes outside the signed 32-bit range, replacing the peer’s code, message and data with a generated parse error. Match the checked-in int64 schema throughout the public error record/accessor, stdio numeric parser and generated-error helper paths. Incoming errors and outgoing callback replies now retain the same values on both architectures.
Error.CodeandRPCError.Code()now useint64instead ofint. Untyped protocol constants retain their names and values. Required/null handling, aliases, duplicate selection and sticky failures, fractional/exponent/out-of-range rejection, raw data ownership, diagnostic policy and request correlation stay covered.Validation: executed 386 regression has eight meaningful pre-fix failures and eight passing controls. Expanded executed 386 coverage includes public error identity/formatting, all eight signed boundary codes through actual incoming and outgoing pipes, malformed-error recovery and schema cases. A focused 386 CI step executes those error checks on every PR. Formatting, module tidiness, build, vet, lint, ordinary/race suites, focused schema/error checks, the exact new 386 CI command and RPC-error fuzzing (30,036 executions) pass. Independent full-patch review found no outstanding findings or material evidence gaps.
Closes #266.