Repository navigation
fix(protocol)!: preserve elicitation metadata numbers - #317
Merged
Merged
Conversation
Decode arbitrary request metadata as exact JSON numbers before handler delivery in every elicitation mode. BREAKING CHANGE: decoded numbers in McpServerElicitationRequestParams.Meta now use json.Number instead of float64.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP elicitation request metadata was decoded through float64 before application callbacks, rounding large integers and rejecting otherwise valid numbers outside float64 range. Decode
_metawith the existing exact-number wire helper in all four modes, so nested values and echoed response metadata retain their numeric tokens.The public
Metafield remainsinterface{}, but decoded numbers now have dynamic typejson.Number. Existing mode/variant admission, exact field matching, duplicate selection, native errors, receiver ownership, raw OpenAI schemas and application-constructed response encoding remain covered.Validation: public regression fails before the fix in all four modes; focused callback/echo, rejection/recovery, native-error reference, duplicate/ownership and generated round-trip checks. Formatting, module tidiness, build, vet, lint, ordinary/race suites, focused schema checks and fuzzing (31,306 executions) pass. Independent full-patch review found no outstanding findings or evidence gaps. Complete local callback-and-reply measurements cover small metadata, 16,384 numbers and a 1 MiB string in every mode. Numeric-array allocations increase about 24–26% in bytes and 50% in count to preserve tokens; observed latency ratios are 0.961–1.091 versus the prior revision.
Closes #258.