Repository navigation
Open the socket to a separate address from the URL host - #146
Closed
jasonharmongit wants to merge 1 commit into
Closed
jasonharmongit wants to merge 1 commit into
jasonharmongit wants to merge 1 commit into
Conversation
The Host header, TLS server name, and certificate check still use the URL host. Co 8000 -authored-by: Cursor <cursoragent@cursor.com>
Author
|
Closed because this was opened against the wrong repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebSockex always opened the socket to the host in the URL, so the TCP address, the
Hostheader, and the TLS name were the same value. Dialing an IP meant putting that IP in the URL, and the handshake then checked the certificate against the IP.This change adds a
:connect_hostoption and pointsopen_socketat it. TheHostheader, the TLS server name, and the certificate check stay on the URL host, so the server still sees the name the client requested. If the option is left out, the socket opens to the URL host, same as before.