8000 Create termination error message · Issue #30 · dominicletz/websockex · GitHub
[go: up one dir, main page]

Skip to content

Create termination error message #30

Open

Description

@Azolo

When any of the :gen modules terminate the create an error log. WebSockex should do that too.

Activity

  1. jurta commented on Jul 18, 2017

    @jurta

    Yes, this is important because currently a WebSockex process exits silently in case of errors. Also please mention the terminate/2 callback in documentation and examples to highlight the importance of error reporting in terminate/2.

  2. Azolo commented on Jul 18, 2017

    @Azolo
    CollaboratorAuthor

    @jurta It shouldn't be completely silent. If there was an error or any other kind of non-normal exit then there would at least be an exit message that was printed. If it was an error in a callback then it should also have a stacktrace associated with it.

    If that's not happening, then I would consider it a bug.

    As for the documentation, PRs are welcome. 😺

  3. khodzha commented on Sep 9, 2017

    @khodzha

    not creating new issue, but what's the proper way to disconnect from server?

  4. Azolo commented on Sep 14, 2017

    @Azolo
    CollaboratorAuthor

    not creating new issue, but what's the proper way to disconnect from server?

    I think that is a really good documentation issue. But the proper way is to send a close message.

    The easiest way to do this is probably with a :close callback return from a cast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0