Repository navigation
Add fail backoff after ACME errors - #9
Merged
Merged
Conversation
Store last_fail per domain on issuance failure. Honor retry-after when present, else wait 1h (5m for unknown errors). This stops per-handshake order storms after HTTP 429. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 17a684e. Configure here.
| CertMagex.Storage.delete({:last_fail, @domain}) | ||
|
|
||
| assert CertMagex.Storage.lookup({:last_fail, @domain}) == nil | ||
| end |
There was a problem hiding this comment.
Stub test never clears backoff
Low Severity
The successful issuance clears a prior fail backoff test inserts a last_fail value and immediately deletes it, then asserts the key is gone. It never runs issuance, so a regression in the success-path clear of last_fail would not be caught.
Reviewed by Cursor Bugbot for commit 17a684e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stores last_fail per domain on issuance failure. Honors retry-after when present, else 1h (5m for unknown errors). Stops per-handshake order storms after HTTP 429. Tests: worker_backoff_test.exs. Follows up with diode_node dep bump and as1-only deploy.
Made with Cursor