Repository navigation
fix/0.6.1-hygiene: version sync, enum-registry parity, parser auto-select, API key guard #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5e16f43
f2dc511
cc17387
b5a1928
2e28704
eae170a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,18 +4,33 @@ | |
|
|
||
|
|
||
| class PackageManagerType(Enum): | ||
| """Package managers supported by the parser registry. | ||
|
|
||
| Every value must have a matching entry in ``parsers.PARSER_REGISTRY``. | ||
| """ | ||
|
|
||
| APT = "apt" | ||
| PACMAN = "pacman" | ||
| DNF = "dnf" | ||
| ZYPPER = "zypper" | ||
| BREW = "brew" | ||
| SPACK = "spack" | ||
| FLATPAK = "flatpak" | ||
| SNAP = "snap" | ||
| NIX = "nix" | ||
| GUIX = "guix" | ||
| FLATPAK = "flatpak" | ||
| CARGO = "cargo" | ||
| NPM = "npm" | ||
| CONDA = "conda" | ||
| PORTAGE = "portage" | ||
| XBS = "xbps" | ||
| APK = "apk" | ||
| ZYPPER = "zypper" | ||
| YUM = "yum" | ||
| PIP = "pip" | ||
| GEM = "gem" | ||
| YARN = "yarn" | ||
| COMPOSER = "composer" | ||
| VCPKG = "vcpkg" | ||
| NUGET = "nuget" | ||
| WINGET = "winget" | ||
| SCOOP = "scoop" | 8||
| CHOCO = "choco" | ||
|
Comment on lines
12
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: #!/bin/bash
set -euo pipefail
rg -n \
'PackageManagerType\.(SPACK|NIX|GUIX|XBS)|\b(spack|nix|guix|xbs)\b' \
--glob '*.py' --glob '*.md' --glob '*.yml' --glob '*.yaml' .Repository: dominicusin/package-maximizer Length of output: 167 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '--- enum definition ---'
cat -n package_maximizer/core/enums.py
printf '%s\n' '--- repository files relevant to package-manager support ---'
git ls-files | rg '(^|/)(README|CHANGELOG|docs|package_maximizer|tests|pyproject|setup|tox|mypy|\.github)' | head -200
printf '%s\n' '--- enum references and supported-value declarations ---'
rg -n \
'PackageManagerType|SPACK|NIX|GUIX|XBS|spack|nix|guix|xbs|package manager|package_manager' \
--glob '*.py' --glob '*.md' --glob '*.yml' --glob '*.yaml' \
package_maximizer tests README* docs pyproject.toml setup.py setup.cfg 2>/dev/null || trueRepository: dominicusin/package-maximizer Length of output: 14667 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '--- public enum exports ---'
sed -n '1,110p' package_maximizer/__init__.py
sed -n '1,40p' package_maximizer/core/__init__.py
printf '%s\n' '--- enum construction paths ---'
sed -n '35,70p' package_maximizer/core/maximizer.py
sed -n '75,100p' package_maximizer/cli/main.py
sed -n '270,292p' package_maximizer/web/app.py
printf '%s\n' '--- parser registry contract ---'
rg -n -A35 -B8 'PARSER_REGISTRY|PackageManagerType' package_maximizer/parsers package_maximizer/coreRepository: dominicusin/package-maximizer Length of output: 26463 Retain deprecated members or document the breaking API change.
🤖 Prompt for AI Agents |
||
|
|
||
|
|
||
| class SolverType(Enum): | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| """Root conftest — sets PM_API_KEY before test modules import web.app.""" | ||
|
|
||
| import os | ||
|
|
||
| # Ensure PM_API_KEY is set BEFORE any test module imports | ||
| # ``package_maximizer.web.app`` (which reads it at import time). | ||
| os.environ.setdefault("PM_API_KEY", "test-key-for-tests") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Preserve coverage for the missing-
🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the incomplete changelog rewrite.
The
Changedentries claim that thePlannedsection was removed, but Lines 35-37 still contain it. Line 21 also creates a second[0.6.0]heading while Line 49 already defines that release. Restore the first heading to[0.5.0] - 2026-08-31or merge the release blocks, then remove the stale subsection or correct the changelog entry.Also applies to: 21-21
🤖 Prompt for AI Agents