Repository navigation
feat(web): add /api/v1/managers endpoint listing 22 package managers - #62
Conversation
- New endpoint GET /api/v1/managers returns all registered package managers - Added tests for the new endpoint - Tests: 501 passed, 2 skipped, 86% total coverage
PR Summary by QodoExpose registered package managers through the web API
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Documentation build overview
|
Code Review by Qodo
1. Managers endpoint undocumented
|
|
|
||
|
|
||
| # ─── List available managers (package managers) ────────────── | ||
| @app.get("/api/v1/managers") |
There was a problem hiding this comment.
1. Managers endpoint undocumented 🐞 Bug ≡ Correctness
The live /api/v1/managers route is missing from both /api/v1/openapi.json and /api/v1/docs. API consumers relying on either advertised documentation surface cannot discover the new endpoint.
Agent Prompt
## Issue description
The new `GET /api/v1/managers` route is exposed by Flask but omitted from both the machine-readable OpenAPI paths and the human-readable docs page, leaving the published API descriptions incomplete.
## Issue Context
The project maintains these documentation surfaces manually in `package_maximizer/web/app.py`. Add the managers operation and response description to the OpenAPI map, add the route to the HTML endpoint list, and strengthen tests to assert that both surfaces include it.
## Fix Focus Areas
- package_maximizer/web/app.py[222-238]
- package_maximizer/web/app.py[542-632]
- tests/test_web_api.py[81-90]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
|
||
| [tool.setuptools_scm] | ||
| fallback_version = "0.5.0" | ||
| fallback_version = "0.6.0" |
There was a problem hiding this comment.
2. Runtime version remains stale 🐞 Bug ≡ Correctness
Changing only setuptools_scm.fallback_version to 0.6.0 can produce distribution metadata for 0.6.0 while the imported package, health endpoint, and OpenAPI document still report 0.5.0. Version checks and production diagnostics therefore return contradictory release identities.
Agent Prompt
## Issue description
The fallback package version is bumped to `0.6.0`, but every runtime-facing version value remains hard-coded to `0.5.0`, creating inconsistent package metadata and API/runtime output when the fallback is used.
## Issue Context
Use a single authoritative runtime version source, preferably distribution metadata with an appropriate source-tree fallback, and have the package attribute, health response, and OpenAPI info consume it. Update the version assertion accordingly so tests detect future drift.
## Fix Focus Areas
- pyproject.toml[78-79]
- package_maximizer/__init__.py[1-7]
- package_maximizer/web/app.py[164-178]
- package_maximizer/web/app.py[542-552]
- tests/test_basic.py[6-15]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
Warning Review limit reachedNext included review available in 16 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Test plan