8000 test(phase1): solver test coverage + weighted-conflict bugfixes by dominicusin · Pull Request #51 · dominicusin/package-maximizer · GitHub
[go: up one dir, main page]
Skip to content

test(phase1): solver test coverage + weighted-conflict bugfixes - #51

Merged
dominicusin merged 1 commit into
mainfrom
feat/wave18
Aug 31, 2026
Merged

test(phase1): solver test coverage + weighted-conflict bugfixes#51
dominicusin merged 1 commit into
mainfrom
feat/wave18

Conversation

@dominicusin
@dominicusin dominicusin commented Aug 31, 2026
Copy link
8000 Copy Markdown
Owner

Этап 1 стратегического плана — поднятие покрытия тяжёлых солверов.

Добавлено:

  • tests/test_solvers_unified.py: параметризованные тесты (конфликты/зависимости/version) через все 7 солверов via get_solver.
  • tests/test_solvers_weighted.py: solve_with_weights + version-constraints.
  • tests/test_solvers_ortools_pulp.py: большие наборы, dependency chains.

Исправлены баги, вскрытые тестами:

  • z3_solver.solve_with_weights: Real(weights.get(...)) -> RealVal (float не принимался Z3, падал).
  • minisat_solver.solve_with_weights: жадный цикл не проверял конфликты с уже выбранными (возвращал несовместимое множество).
  • enhanced_greedy.solve_with_weights: remove-стратегия вытесняла более тяжёлые пакеты (нарушала семантику весов).

Результат: 404 passed (было 308), покрытие солверов выросло (maxsat 90%, minisat 82%, z3 82%, enhanced_greedy 86%).

🤖 Generated with Claude Code

@qodo-code-review
qodo-code-review Bot commented Aug 31, 2026
Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai
coderabbitai Bot commented Aug 31, 2026
Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 39 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ec504358-08cf-4881-bcf4-f756fadb6a20

📥 Commits

Reviewing files that changed from the base of the PR and between 92012d1 and ca7f639.

📒 Files selected for processing (6)
  • package_maximizer/solvers/enhanced_greedy.py
  • package_maximizer/solvers/minisat_solver.py
  • package_maximizer/solvers/z3_solver.py
  • tests/test_solvers_ortools_pulp.py
  • tests/test_solvers_unified.py
  • tests/test_solvers_weighted.py

Thanks for us A2E7 ing CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dominicusin
dominicusin merged commit 4030870 into main Aug 31, 2026
16 of 17 checks passed
@dominicusin
dominicusin deleted the feat/wave18 branch August 31, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dominicusin
0