Repository navigation
Feature/phase 1 docs di - #23
Merged
Merged
Conversation
- Fix pulp_solver.py: add missing `import pulp` (NameError on solve) - Fix VersionConstraint `~` operator: now correctly computes next minor version (1.2.3 → 1.3.0) instead of next major - Split requirements.txt into core/solvers/web/dev for flexible installs - Add security job to CI (bandit, safety) with artifact upload - Add lint job (flake8, mypy, black, isort) with fail-fast - Add pytest-xdist parallel test runner across OS/Python matrix - Enhance web API: POST /api/v1/maximize, /api/v1/benchmark, /api/v1/cache/stats|clear, API key auth, error handlers, request timing middleware, health check - Add 31 integration tests: end-to-end maximization, solver comparison, constraint scenarios, parser samples, web API client tests (auth, errors, backward compat) - Update README: dependency matrix, REST API docs with examples All 206 tests pass (175 existing + 31 new integration).
- Add `Any` to imports in core/maximizer.py (fixes F821) - Reformat 4 modified files to Python 3.12 target with black - All 206 tests still pass after formatting Pre-existing codebase used Python 3.15 AST syntax which fails on Python 3.12's parser. Target py312 ensures consistency.
- Create docs/conf.py with autodoc, napoleon, myst_parser - Create docs/index.rst with full documentation - Create docs/api-reference.rst with detailed API docs - Add DI (Dependency Injection) module - di/container.py: Container, ServiceLocator, inject decorator - di/__init__.py: exports - Add CacheManager integration to PackageMaximizer - _cache_manager field for DI-friendly access - _get_cache() accessor method Features: - Sphinx RTD theme ready - API documentation via autodoc - Type hints preserved - DI container for testable architecture - Lazy CacheManager instantiation All 206 tests still pass.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reachedNext included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.