8000 fix(a11y): align Blowfish search aria-label with shortcut hint by dominicusin · Pull Request #451 · dominicusin/dominicusin.github.io · GitHub
[go: up one dir, main page]
Skip to content

fix(a11y): align Blowfish search aria-label with shortcut hint - #451

Merged
dominicusin merged 5 commits into
mainfrom
uaw/fix-blowfish-search-i18n-2026-10-19
Oct 23, 2026
Merged

fix(a11y): align Blowfish search aria-label with shortcut hint#451
dominicusin merged 5 commits into
mainfrom
uaw/fix-blowfish-search-i18n-2026-10-19

Conversation

@dominicusin
@dominicusin dominicusin commented Oct 20, 2026 •
edited by coderabbitai Bot
Loading
Copy link
Copy Markdown
Owner

Summary

Fixes Linear DOM-7.

The Playwright E2E run #811 failed four desktop accessibility checks with axe rule label-content-name-mismatch on #search-button. The rendered button exposed aria-label="Поиск (/)" while its visible keyboard hint is ⌘K.

The pinned Blowfish theme defines a nested search: translation map. The site locale overrides used dotted scalar keys (search.open_button_title), so they did not override the nested theme values.

Changes

  • Replace dotted search locale keys with native nested search: mappings for Russian and English.
  • Include the visible ⌘K shortcut in both accessible name/title strings: Открыть поиск (⌘K) / Open search (⌘K).
  • Define nested input and close-button labels while retaining legacy flat placeholders.

Validation — passed

Safety

This remains a draft PR and has not been merged. Do not merge to main or deploy production as part of this remediation.

Summary by CodeRabbit

  • Localization
    • Search input, close-button, and open-button labels are now grouped under nested search translations in English and Russian.
    • The Russian open-search label now includes the ⌘K keyboard shortcut hint.

@bolt-new-by-stackblitz
bolt-new-by-stackblitz Bot commented Oct 20, 2026
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
vercel Bot commented Oct 20, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dominicusin-github-io Error Error Oct 23, 2026 6:15pm UTC
3 Skipped Deployments
Project Deployment Actions Updated
dominicusin-dominicusin.github.io Ignored Ignored Preview Oct 23, 2026 6:15pm UTC
dominicusin-dominicusin.github.io-lw64 Ignored Ignored Preview Oct 23, 2026 6:15pm UTC
dominicusin-github-io-5612 Ignored Ignored Preview Oct 23, 2026 6:15pm UTC

@github-actions
github-actions Bot commented Oct 20, 2026
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai
coderabbitai Bot commented Oct 20, 2026 •
edited
Loading
Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c6eb8a09-1bdf-4569-bbb5-bacb167c0cbb
📥 Commits

Reviewing files that changed from the base of the PR and between 6952530 and 2429e01.

📒 Files selected for processing: 2
  • i18n/en.yaml
  • i18n/ru.yaml
+--------------------------------------------------------------------------------------------------------------------------------+
| Test state coverage, not code coverage. Identify and test significant program states. Just testing lines of code isn't enough. |
+--------------------------------------------------------------------------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI 8000 , and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dominicusin
dominicusin marked this pull request as ready for review October 23, 2026 16:56
@dominicusin
dominicusin enabled auto-merge (squash) October 23, 2026 16:56
@qodo-code-review
qodo-code-review Bot commented Oct 23, 2026
Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@dominicusin
dominicusin merged commit 0732e58 into main Oct 23, 2026
18 of 24 checks passed
@dominicusin
dominicusin deleted the uaw/fix-blowfish-search-i18n-2026-10-19 branch October 23, 2026 16:59

This branch had an error being deployed

1 failed deployment
Preview – dominicusin-github-io — 2429e015 Deployed Oct 23, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dominicusin
0