Repository navigation
Conversation
Contributor
|
lgtm |
Owner
|
hang on... don't we use |
Owner
|
what is the best way to handle this? |
Author
|
hm, does sublevel allow closing the underlying db at all? The close method in sublevel doesn't seem to pass through the close() method emitter.close = function (cb) {
//TODO: deregister all hooks
process.nextTick(cb || function () {})
}EDIT: my bad, didn't know about multilevel, so assumed you meant multi level with sublevel |
Owner
|
yeah... it would be okay for the toplevel sublevel to close the db... but it wouldn't make sense for the nested sublevels to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.