Repository navigation
Size Text columns in DDL in characters rather than bytes - #56
Merged
Merged
Conversation
- Jet4 and later store two bytes a character of Text, but the DDL took the stored size in bytes as the length, so a column of 255 characters became TEXT(510) or VARCHAR(510), past the limit of 255 of a Short Text in Access and twice the length in the other dialects - Add is_jet3 to TableDef, set by read_table_def; the DDL halves the size of a Text column of Jet4 and later, and keeps it for Jet3, which stores 8000 one byte a character - Update the test that expected the size, the package test, and the examples in docs/cli.md and docs/cli.ja.md - Add a test of Text sizes of Jet4 and later and of Jet3; on all the test databases only the Text sizes in the PostgreSQL, MySQL and Access DDL of Jet4 and later files change Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TEXT(510)in the Access DDL, past the limit of 255, andVARCHAR(510)in PostgreSQL and MySQL, twice its length;COL_NAMEofTable1in enc_vbaV2000.mdb is one.TableDefgainsis_jet3, set byread_table_def. The DDL halves the size of a Text column of Jet4 and later, and keeps it for Jet3, which stores one byte a character. ATableDefbuilt outside the crate needs the new field.🤖 Generated with Claude Code