Repository navigation
Keep the rules the CLI and jetdb-wasm share in the library - #40
Merged
Merged
Conversation
- The CLI and jetdb-wasm each had the same table from JetVersion to its short name (JET3, JET4, ACE12 to ACE17) - Add JetVersion::short_name to the library, use it from both, and move the test of the names from the CLI to the library Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- The library, the CLI and jetdb-wasm each tested the system and hidden flags of a catalog entry themselves, in seven places - Add CatalogEntry::is_system and CatalogEntry::is_system_or_hidden, and use them everywhere the flags were tested; the test that checks the flag of MSysObjects itself is unchanged Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- jetdb export, jetdb schema and jetdb-wasm each searched the catalog for a table of a given name and returned TableNotFound when there was none - Add find_table to the library and use it in all three; the data macros of a table are still found by their own search, as they are read from the raw MSysObjects rows rather than the catalog Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- column_flags::REPLICATION and is_replication_column were named for replication, but the flag marks every column Access maintains and hides from users, such as every column of a system table - Add column_flags::HIDDEN and ColumnDef::is_hidden, and use them in the CLI and jetdb-wasm - Keep REPLICATION and is_replication_column, with the same value and answer, as deprecated, so that code using them still compiles with a warning Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- jetdb export and jetdb-wasm each decided which columns to show the same way: hidden columns are left out, except in a system table, where every column is hidden - Add ColumnDef::is_shown to the library and use it in both; export still shows every column with --system-columns - Move the test of the rule from jetdb-wasm to the library Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- jetdb export, jetdb prop and jetdb-wasm each spelled out the default formats, the date alone at midnight and the date and time otherwise - Add DEFAULT_DATE_FORMAT, DEFAULT_DATETIME_FORMAT and format_default to the timestamp module, and use them for the defaults of export's --date-format and --datetime-format, in prop, and in jetdb-wasm Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- The help and docs called the columns that export leaves out by default replication system columns, but they are the columns Access maintains and hides, as column_flags::HIDDEN is now named - Reword the help of --system-columns and the export sections of docs/cli.md and docs/cli.ja.md; the option itself is unchanged Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JetVersion::short_name: the short version names (JET3toACE17)CatalogEntry::is_systemandis_system_or_hidden: which catalog entries are system or hidden objects, also used bytable_namescatalog::find_table: a table by name, orTableNotFoundColumnDef::is_shown: which columnsexportand jetdb-wasm show by defaulttimestamp::format_defaultwithDEFAULT_DATE_FORMATandDEFAULT_DATETIME_FORMAT: a timestamp asexportwrites it by defaultcolumn_flags::REPLICATION, withis_replication_column, but it marks the columns Access maintains and hides, such as every column of a system table. Addcolumn_flags::HIDDENandColumnDef::is_hidden, and keep the former names, with the same value and answer, as deprecated. The help ofexport --system-columnsanddocs/cli.md/docs/cli.ja.mdnow describe these columns the same way.🤖 Generated with Claude Code