8000 Fix EventOnly behaviour by emgre · Pull Request #385 · dnp3/opendnp3 · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Fix EventOnly behaviour - #385

Merged
jadamcrain merged 3 commits into
developfrom
bugfix/event-only
Jun 5, 2020
Merged

jadamcrain merged 3 commits into
developfrom
bugfix/event-only

Conversation

@emgre
@emgre emgre commented Jun 3, 2020
Copy link
Copy Markdown
Member

Fix #384.

  • Fix EventOnlybehaviour to match the 2.x.
  • Updated outstation example adapter. 0.0.0.0 is more common default than asdf.
  • Updated TLS examples to be consistent.

@codecov
codecov Bot commented Jun 3, 2020 •
Copy link
Copy Markdown

Codecov Report

Merging #385 into develop will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #385      +/-   ##
===========================================
- Coverage    51.75%   51.72%   -0.03%     
===========================================
  Files          456      456              
  Lines        13602    13602              
===========================================
- Hits          7040     7036       -4     
- Misses        6562     6566       +4     
Impacted Files Coverage Δ
cpp/lib/src/outstation/StaticDataMap.h 94.39% <100.00%> (ø)
cpp/lib/src/channel/IOHandler.cpp 77.09% <0.00%> (-3.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279788e...8774003. Read the comment docs.

/// Never produce an event regardless of changes
Suppress = 0x2,
/// Send an event directly to the event buffer, bypassing the static value completely
/// Force the creation of an event bypassing detection mechanism, but does not
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update this comment via the code generator. It will also update java/.net

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ My bad

@jadamcrain
jadamcrain merged commit 9dcc7ac into develop Jun 5, 2020
@jadamcrain
jadamcrain deleted the bugfix/event-only branch June 5, 2020 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0