8000 check if _MSC_VER exists for when mingw is used by nnminh171298 · Pull Request #345 · dnp3/opendnp3 · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

check if _MSC_VER exists for when mingw is used - #345

Merged
emgre merged 1 commit into
dnp3:release-2.xfrom
nnminh171298:patch-1
Apr 17, 2020
Merged

emgre merged 1 commit into
dnp3:release-2.xfrom
nnminh171298:patch-1

Conversation

@nnminh171298
Copy link
Copy Markdown

No description provided.

@jadamcrain
Copy link
Copy Markdown
Member

This looks good. Can you target the develop branch where we're working on the 3.0 release? If you need this on 2.x soon we can work out how we want to stage hotfixes before doing fixes on the 2.x release branch.

@emgre
emgre commented Dec 12, 2019
Copy link
Copy Markdown
Member

Actually, we don't need a fix in the develop branch, SteadyClockWindows does not exist anymore. Instead, we check in the CMake that MSVC >= 2015 and we don't support the older versions.

@emgre
emgre merged commit 23fa25f into dnp3:release-2.x Apr 17, 2020
@nnminh171298
nnminh171298 deleted the patch-1 branch April 17, 2020 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0