8000 Java `CommandHeader` builder methods now all return `CommandHeaders` by emgre · Pull Request #440 · dnp3/opendnp3 · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Java CommandHeader builder methods now all return CommandHeaders #440

Merged
emgre merged 2 commits into from
Apr 21, 2022
Merged

Java CommandHeader builder methods now all return CommandHeaders #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f41cc9
In Java, `CommandHeader` builder methods now all return `CommandHeade…
emgre Apr 18, 2022
0140375
Merge branch 'develop' into bugfix/java-command-headers
emgre Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
(due to ICMP packets) do not close the socket immediately. See [#438](https://github.com/dnp3/opendnp3/pull/438).
* :coffin: Deprecate the `LinkConfig` constructor with an unused `useConfirms` argument.
See [#439](https://github.com/dnp3/opendnp3/pull/439).
* :beetle: In Java, `CommandHeader` builder methods now all return `CommandHeaders`.
See [#440](https://github.com/dnp3/opendnp3/pull/440).

### 3.1.1 ###
* :beetle: Fix static octet string serilazation bug.
Expand Down
12 changes: 6 additions & 6 deletions java/bindings/src/main/java/com/automatak/dnp3/CommandHeader.java
View file
Open in desktop
< 85DE td id="diff-4f2e4b4002b016f89de36ae3d9f2ef44697e5faad4e5799e24b69a7148428bdfL58" data-line-number="58" class="blob-num blob-num-context js-linkable-line-number">
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,17 @@ public static CommandHeaders fromAO16(Iterable<IndexedValue<AnalogOutputInt16>>
return new CommandHeader((CommandBuilder b) -> b.addAO16(commands));
}

public static CommandHeader fromAO32(Iterable<IndexedValue<AnalogOutputInt32>> commands)
public static CommandHeaders fromAO32(Iterable<IndexedValue<AnalogOutputInt32>> commands)
{
return new CommandHeader((CommandBuilder b) -> b.addAO32(commands));
}

public static CommandHeader fromAOFloat32(Iterable<IndexedValue<AnalogOutputFloat32>> commands)
public static CommandHeaders fromAOFloat32(Iterable<IndexedValue<AnalogOutputFloat32>> commands)
{
return new CommandHeader((CommandBuilder b) -> b.addAOFloat32(commands));
}

public static CommandHeader fromAODouble64(Iterable<IndexedValue<AnalogOutputDouble64>> commands)
public static CommandHeaders fromAODouble64(Iterable<IndexedValue<AnalogOutputDouble64>> commands)
{
return new CommandHeader((CommandBuilder b) -> b.addAODouble64(commands));
}
Expand All @@ -69,17 +69,17 @@ public static CommandHeaders fromSingleAO16(AnalogOutputInt16 command, int index
return fromAO16(wrap(command, index));
}

public static CommandHeader fromSingleAO32(AnalogOutputInt32 command, int index)
public static CommandHeaders fromSingleAO32(AnalogOutputInt32 command, int index)
{
return fromAO32(wrap(command, index));
}

public static CommandHeader fromSingleAOFloat32(AnalogOutputFloat32 command, int index)
public static CommandHeaders fromSingleAOFloat32(AnalogOutputFloat32 command, int index)
{
return fromAOFloat32(wrap(command, index));
}

public static CommandHeader fromSingleAODouble64(AnalogOutputDouble64 command, int index)
public static CommandHeaders fromSingleAODouble64(AnalogOutputDouble64 command, int index)
{
return fromAODouble64(wrap(command, index));
}
Expand Down
0