8000 Fix external table SQL rewriting by eddiethedean · Pull Request #84 · dmux/minilake · GitHub
[go: up one dir, main page]

Skip to content

Fix external table SQL rewriting - #84

Merged
dmux merged 5 commits into
dmux:mainfrom
eddiethedean:codex/fix-issue-41-external-sql-rewriting
Oct 26, 2026
Merged

dmux merged 5 commits into
dmux:mainfrom
eddiethedean:codex/fix-issue-41-external-sql-rewriting

Conversation

@eddiethedean
@eddiethedean eddiethedean commented Oct 26, 2026 •
Copy link
Copy Markdown
Collaborator

Registering an external table previously changed SQL string literals containing its fully qualified name. External table references are now rewritten in relation positions, and storage paths are safely quoted.

The scanner handles nested queries, joins, pivot sources, and external sources in DELETE and MERGE, while preserving literals, comments, aliases, and expression-level FROM syntax.

Closes #41

Validation

  • SQL statement and real Delta API regression tests: 67 passed, including DELETE and MERGE source cases.
  • Ruff lint, formatting, and git diff --check passed.

@eddiethedean
Copy link
Copy Markdown
Collaborator Author

All CI checks pass. This PR is ready to merge.

@dmux dmux self-assigned this Oct 26, 2026
@dmux dmux added the bug Something isn't working label Oct 26, 2026
@dmux
dmux merged commit 893d455 into dmux:main Oct 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] External-table SQL rewriting changes string literals

2 participants

0