8000 Preserve SQL types in Arrow results by eddiethedean · Pull Request #83 · dmux/minilake · GitHub
[go: up one dir, main page]

Skip to content

Preserve SQL types in Arrow results - #83

Merged
dmux merged 6 commits into
dmux:mainfrom
eddiethedean:codex/fix-issue-42-arrow-type-preservation
Oct 26, 2026
Merged

dmux merged 6 commits into
dmux:mainfrom
eddiethedean:codex/fix-issue-42-arrow-type-preservation

Conversation

@eddiethedean
@eddiethedean eddiethedean commented Oct 26, 2026 •
Copy link
Copy Markdown
Collaborator

Summary

  • Preserve DuckDB Arrow schemas, values, and extension metadata when serving ARROW_STREAM chunks, including binary, nested, null-only, and empty results.
  • Keep JSON statement serialization unchanged and add regressions for typed values, dates outside Python's range, and opaque Arrow metadata.

Fixes #42

Validation

  • uv run pytest -q tests/test_sql_statements.py (44 passed)
  • uv run ruff check src/minilake/services/sql_statements.py tests/test_sql_statements.py
  • uv run ruff format --check src/minilake/services/sql_statements.py tests/test_sql_statements.py

@eddiethedean
Copy link
Copy Markdown
Collaborator Author

All CI checks are passing. This PR is ready to merge.

@dmux dmux added the bug Something isn't working label Oct 26, 2026
@dmux dmux self-assigned this Oct 26, 2026
@dmux
dmux commented Oct 26, 2026
Copy link
Copy Markdown
Owner

LGTM! 🚀

@dmux
dmux merged commit bc894b8 into dmux:main Oct 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Arrow result serialization loses SQL types and binary bytes

2 participants

0