8000 Fix DBFS and Files with relative data directories by eddiethedean · Pull Request #82 · dmux/minilake · GitHub
[go: up one dir, main page]

Skip to content

Fix DBFS and Files with relative data directories - #82

Merged
dmux merged 4 commits into
dmux:mainfrom
eddiethedean:codex/fix-issue-43-relative-data-root
Oct 26, 2026
Merged

dmux merged 4 commits into
dmux:mainfrom
eddiethedean:codex/fix-issue-43-relative-data-root

Conversation

@eddiethedean
Copy link
Copy Markdown
Collaborator

Summary

  • Resolve the DBFS and Files storage roots before checking that resolved paths stay within the root.
  • Add real HTTP coverage for DBFS and Files writes with a relative MINILAKE_DATA_DIR.
  • Cover relative, absolute, and symlinked roots, including traversal and symlink escape rejection.

Validation

  • uv run ruff check src/minilake/services/dbfs.py src/minilake/services/files.py tests/test_persistence.py tests/test_dbfs_files_path_resolution.py
  • uv run pytest -q tests/test_dbfs.py tests/test_files.py tests/test_dbfs_files_path_resolution.py tests/test_persistence.py::test_relative_data_dir_supports_dbfs_and_files (19 passed)

Closes #43

@eddiethedean
Copy link
Copy Markdown
Collaborator Author

This PR is ready to merge. All checks are passing.

@dmux dmux self-assigned this Oct 26, 2026
@dmux dmux added the bug Something isn't working label Oct 26, 2026
@dmux
dmux merged commit be2aa12 into dmux:main Oct 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] DBFS and Files reject every path with a relative data directory

2 participants

0