Repository navigation
[BUG] Restore persisted jobs and runs by numeric ID - #73
Merged
Merged
Conversation
Collaborator
Author
|
Ready to merge once the remaining CI check passes. Reviewed the full PR at commit Lint and UI checks pass. The full Docker test CI job is still running. |
asabla
pushed a commit
to asabla/pond
that referenced
this pull request
Nov 5, 2026
MiniLake 1.9.0 restored its snapshot with string keys, so after a restart
every job and run lookup by id failed ("Run 5 not found") while the lists
still showed them. 1.9.1 converts the ids back (dmux/minilake#73) and fixes
several other persistence and SQL issues.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restoring persisted jobs, runs, and task outputs converts their JSON object keys back to integer IDs so existing ID-based API operations continue to work after restart. The regression test covers job get/list/update, run get/rerun, SQL task output, and counter continuity across a real process restart.
Fixes #36.
Validation
git diff --checkpasses.