Repository navigation
[BUG] Honor overwrite=false for chunked DBFS uploads - #66
Merged
Merged
Conversation
Collaborator
Author
|
This PR is ready to merge. Review of commit 0a08b74 found no high or critical defects. All CI checks passed, including lint, UI, and the Docker test suite. Isolated review checks also passed for upload conflicts, retries, write-failure cleanup, explicit overwrite, and concurrent publication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
Chunked uploads checked
overwrite=falseonly when the handle was opened. If another upload orputcreated the path before close,closeoverwrote that file and discarded its contents.For no-overwrite handles, close now writes the buffered content to a temporary file in the destination directory and publishes it with an atomic hard link. The link fails if a destination already exists, including one created after the handle was opened. The handle stays available if the close fails, so the caller can recover or retry.
overwrite=truekeeps its existing replacement behavior.Validation: Ruff format, Ruff check, and
git diff --checkpassed. The PR CI suite will run on GitHub.