Repository navigation
[BUG] Preserve existing DBFS move destinations - #65
Merged
Merged
Conversation
Collaborator
Author
|
This PR is ready to merge. The full review of commit ae6e298 is complete with no high or critical findings. All CI checks passed, including lint, UI, and the Docker test suite (409 tests passed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34
dbfs/moveusedPath.rename, which can replace an existing destination and silently discard its contents. Moves now use an exclusive rename where the platform supports it and returnRESOURCE_ALREADY_EXISTSwhen the destination exists. When exclusive rename is unavailable, the move returnsNOT_IMPLEMENTEDwithout changing either path. Regression tests cover existing file and empty directory destinations, plus the unavailable-syscall path.Validation: The focused unavailable-syscall regression test passed, and Ruff lint/format plus
git diff --checkpassed. The original Docker DBFS run passed (8 tests); the Docker daemon currently reports a read-only filesystem, preventing a rebuild and rerun against this follow-up commit.