[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multiplexed-connections feature #114

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Barre
Copy link
@Barre Barre commented Nov 10, 2021

Implement multiplexed connections in order to implement a workaround against issue #95.
This workaround was mentioned by the author of the redis-rs library: redis-rs/redis-rs#325 (comment)

Based on my experience of the last few weeks, the issue didn't occur anymore after using MultiplexedConnection instead of Connection.

@djc
Copy link
Owner
djc commented Nov 10, 2021

Hey, thanks. In the issue I asked if you could explain a bit more about why/how the semantics are different.

I don't think doing this as a feature that changes the connection type makes sense. It could just be a separate ManageConnection implementation in bb8-redis, or potentially we should just semver-bump bb8-redis and always use the MultiplexedConnection, since you'll pretty much want these semantics for pooling anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants