Update Group.py #1045
Closed
Update Group.py #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for KeyError: 'bri'
The error occurred because some lights in a group did not have the bri (brightness) key in their state. To resolve this, the .get() method is used to provide a default value of 0 when bri is not available:
bri = bri + light().state.get("bri", 0)
This ensures that the program doesn't fail when the bri key is missing.
|
Hi thanks for your pull request, the problem with doing it this way is that if its a device without brightness(a plug for example) it is still added to the average causing the average to be lower then the real average. I have a better solution i will push soon. |
|
hi, i made changes to fix this. please try and give feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for KeyError: 'bri'
The error occurred because some lights in a group did not have the bri (brightness) key in their state. To resolve this, the .get() method is used to provide a default value of 0 when bri is not available:
bri = bri + light().state.get("bri", 0)
This ensures that the program doesn't fail when the bri key is missing.