Repository navigation
fix(oauth2): encode permissions as bitfield in authorization url - #571
Merged
topi314 merged 1 commit intoAug 4, 2026
Merged
Conversation
Permissions.String() returns display names, so fmt.Sprint in QueryValues.Encode emitted "Send Messages, Video" instead of the raw bitfield, producing an invalid authorize url.
topi314
approved these changes
Aug 4, 2026
Member
|
good catch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AuthorizationURLParams.Permissionsproduces a broken authorize URL.QueryValues.Encoderenders every value withfmt.Sprint(discord/url.go:18), which picks upPermissions.String()(discord/permissions.go:189). That returns display names, not the bitfield:Discord expects the raw integer, so any caller setting
Permissionsgets an invalid invite URL.MarshalJSONis unaffected — it already emits the numeric string; only the query-value path is wrong.Fix
Pass the raw bitfield explicitly so the
Stringeris bypassed:Plus a regression test asserting the encoded value.