Repository navigation
fix(voice): Conn.Close blocking forever - #547
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adjusts voice connection shutdown signaling and teardown to avoid blocking on closedChan and to close transports immediately when Close() is invoked.
Changes:
- Make the
closedChannotification inHandleVoiceStateUpdatenon-blocking viaselect { case ... default: }. - Simplify
Close()by removing the wait onclosedChanand directly closing the gateway/UDP connection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
topi314
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connImpl.Close()deferredgateway.Close()andudp.Close()to after aselectthat waited onc.closedChan. The channel was only filled byHandleVoiceStateUpdatewhen Discord confirmed the voice leave.In linkdave's case,
voiceStateUpdateFuncis a no-op — so Discord never received the leave andclosedChanwas never signaled.Close()blocked until context timeout, with all resources still open during the wait.I verified this behavior with a modified version of linkdave using
oldVC.Close(context.Background()).2026-06-02.15-43-44-compressed.mp4