8000 feat: community invites by yokkkoso · Pull Request #509 · disgoorg/disgo · GitHub
[go: up one dir, main page]
Skip to content

feat: community invites - #509

Merged
topi314 merged 13 commits into
disgoorg:masterfrom
yokkkoso:feat/invite-roles
Feb 2, 2026
Merged

feat: community invites#509
topi314 merged 13 commits into
disgoorg:masterfrom
yokkkoso:feat/invite-roles

Conversation

@yokkkoso
@yokkkoso yokkkoso commented Jan 20, 2026
Copy link
Copy Markdown
Contributor

DeathHound6
DeathHound6 approved these changes Jan 20, 2026
View reviewed changes
@DeathHound6 DeathHound6 left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good aside from the (seemingly) redundant line

Comment thread discord/invite.go Resolved
topi314
topi314 requested changes Jan 23, 2026
View reviewed changes
@topi314 topi314 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are few new things missing like endpoints
are you planning to add these too?

@yokkkoso
yokkkoso commented Jan 23, 2026
Copy link
Copy Markdown
Contributor Author

there are few new things missing like endpoints are you planning to add these too?

Yeap, just was busy on the work last days

@yokkkoso
yokkkoso commented Jan 23, 2026
Copy link
Copy Markdown
Contributor Author

please check last changes, because I'm not sure this is convenience implementation of UpdateInviteTargetUsers endpoint and whether it's worth using io.Reader

topi314
topi314 requested changes Jan 25, 2026
View reviewed changes
@topi314 topi314 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good

Comment thread discord/invite.go Resolved
Comment thread discord/invite.go Resolved
Comment thread discord/invite.go Resolved
Comment thread rest/rest_endpoints.go Resolved
@yokkkoso
yokkkoso commented Jan 26, 2026
Copy link
Copy Markdown
Contributor Author

I changed everything except PayloadWithFiles, because the main reason I made it a separate function is that the field name in the form data is different and the logic for writing in the functions is different, so I haven't figured out the right way to merge it yet

topi314
topi314 requested changes Jan 27, 2026
View reviewed changes
Comment thread discord/invite.go Resolved
Comment thread discord/invite.go Resolved
Comment thread rest/invites.go Resolved
Comment thread rest/invites.go Resolved
@yokkkoso yokkkoso changed the title feat: invite roles and target users file feat: community invites Jan 30, 2026
@topi314
topi314 merged commit d5987dc into disgoorg:master Feb 2, 2026
4 checks passed
@topi314
topi314 commented Feb 2, 2026
Copy link
Copy Markdown
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@topi314 topi314 topi314 requested changes
+1 more reviewer
@DeathHound6 DeathHound6 DeathHound6 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

t:gateway t:rest type:enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yokkkoso @topi314 @DeathHound6
0