8000 Better DefaultAllowedMentions configuration by TheKodeToad · Pull Request #483 · disgoorg/disgo · GitHub
[go: up one dir, main page]

Skip to content

Better DefaultAllowedMentions configuration - #483

Merged
topi314 merged 3 commits into
disgoorg:masterfrom
TheKodeToad:better-allowed-mentions
Nov 28, 2025
Merged

topi314 merged 3 commits into
disgoorg:masterfrom
TheKodeToad:better-allowed-mentions

Conversation

@TheKodeToad
Copy link
Copy Markdown
Contributor
  • Remove DefaultAllowedMentions global in favour of rest.WithDefaultAllowedMentions
  • Renamed existing ConfigOpt to ClientConfigOpt, ConfigOpts are now for configuring the rest.Rest object instead of rest.Client

Just needs testing with webhooks and interactions...
Also, I didn't touch the webhook package as this pr is big enough

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is a dumb example, IDK
I mainly included this to help reviewers test

@topi314 topi314 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you resolve the pipeline I am pretty sure this is mergeable

@TheKodeToad
Copy link
Copy Markdown
Contributor Author

/shrug I guess I did need to modify the webhook package. Made the option actually do something...

@topi314 topi314 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default allowed mentions handlign is missing in:

  • CreateFollowupMessage
  • interaction responses via outgoing webhooks

@TheKodeToad
Copy link
Copy Markdown
Contributor Author

I should have got everything now

@topi314
topi314 merged commit 078ad24 into disgoorg:master Nov 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants

0