8000 remove `testify` dependency by elisiei · Pull Request #478 · disgoorg/disgo · GitHub
[go: up one dir, main page]

Skip to content

remove testify dependency - #478

Merged
topi314 merged 1 commit into
disgoorg:masterfrom
elisiei:remove-testify
Oct 1, 2025
Merged

topi314 merged 1 commit into
disgoorg:masterfrom
elisiei:remove-testify

Conversation

@elisiei
@elisiei elisiei commented Sep 28, 2025
Copy link
Copy Markdown
Contributor

this pr also fixes a typo in a file name

@apricotbucket28
Copy link
Copy Markdown
Contributor

Why? The code is now more verbose and testify is still in the dependency tree.

@elisiei
elisiei commented Sep 29, 2025
Copy link
Copy Markdown
Contributor Author

the less dependencies the better, the code is still understandable.

i assume it's still there because another dep uses it, but it's not on the go.mod anyways.

@topi314
topi314 commented Sep 29, 2025
Copy link
Copy Markdown
Member

Relevant discord discussion on the DisGo server
This was opened with my approval

https://discord.com/channels/817327181659111454/817327182111571989/1421989591442915518

@topi314
topi314 merged commit fb4115d into disgoorg:master Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants

0