8000 feat: add support for new RATE_LIMIT gateway event by davfsa · Pull Request #464 · disgoorg/disgo · GitHub
[go: up one dir, main page]

Skip to content

feat: add support for new RATE_LIMIT gateway event - #464

Merged
topi314 merged 5 commits into
disgoorg:masterfrom
davfsa:feat/gateway-ratelimited-event
Aug 19, 2025
Merged

topi314 merged 5 commits into
disgoorg:masterfrom
davfsa:feat/gateway-ratelimited-event

Conversation

@davfsa
@davfsa davfsa commented Aug 14, 2025
Copy link
Copy Markdown
Contributor

Signed-off-by: davfsa <davfsa@gmail.com>
davfsa added 2 commits August 14, 2025 13:55
Signed-off-by: davfsa <davfsa@gmail.com>
Signed-off-by: davfsa <davfsa@gmail.com>
@topi314 topi314 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly minor things
the event also needs to be added into the listener adapter in the events package
special handling for the chunking manager I will do then

Comment thread gateway/gateway_events.go Resolved
Comment thread discord/gateway_ratelimited.go 8000 Resolved
Comment thread discord/gateway_ratelimited.go Resolved
Comment thread discord/gateway_ratelimited.go Resolved
Comment thread gateway/gateway_events.go Resolved
Comment thread gateway/gateway_events.go Resolved
Comment thread gateway/gateway_events.go Resolved
Comment thread gateway/gateway_events.go Resolved
Comment thread gateway/gateway_events.go Resolved
Comment thread gateway/gateway_events.go Resolved
@davfsa
davfsa commented Aug 18, 2025
Copy link
Copy Markdown
Contributor Author

@topi314 Just pushed da6bb63 (#464), which should hopefully address all your issues, let me know if you need anything else changed!

@davfsa
davfsa requested a review from topi314 August 18, 2025 16:56
Comment thread events/listener_adapter.go Resolved
Comment thread gateway/gateway_ratelimited.go Resolved
Comment thread gateway/gateway_ratelimited.go Resolved
Comment thread gateway/gateway_events.go Resolved
@davfsa
davfsa requested a review from topi314 August 19, 2025 10:20
@topi314
topi314 merged commit 562fe73 into disgoorg:master Aug 19, 2025
@topi314
topi314 commented Aug 19, 2025
Copy link
Copy Markdown
Member

thanks!

sentinelb51 added a commit to sentinelb51/disgo that referenced this pull request Oct 16, 2026
disgoorg#464 added the RATE_LIMITED gateway event (decoding, EventRateLimited,
events.GatewayRateLimited, ListenerAdapter.OnGatewayRateLimited) but no
handler for it. The gateway hands the decoded dispatch to the event
manager, which found no handler, logged "no handler for Gateway event
found" at warn level and dropped it: GatewayRateLimited never fired, so
nobody could learn that a Request Guild Members was refused or when to
retry. Register a handler that dispatches it.

Proof: TestRateLimitedDispatchesGatewayRateLimited fails before (no
handler for RATE_LIMITED) and passes after.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VRMfn49UbzGanZA9mpsR8F
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants

0