Repository navigation
Miscelaneous minor improvements - #100
Merged
Merged
Conversation
Emitting source files by setting `EmitCompilerGeneratedFiles=true` in the project file is a very convenient way to explore and debug with full sources the output of source generators. In order to make the experience even better, we could improve the formatting a bit, by properly adding missing newlines here and there, only when said flag is set (which would likely be while debugging/learning about a Avatar's internals). Fixes #98.
We had already updated the readme, missing the sync with the package.
The SyntaxExtensions is already C#-only, so no need to have that *and* a CSharpSyntaxExtensions.
Invoke `Get<T>` or `GetNullable<T>` depending on the argument type being retrieved, so that we never generate code that has nullable warnings. Fixes #99.
kzu
enabled auto-merge (rebase)
February 12, 2021 16:26
This makes them mostly an example of what generated avatars look like, but otherwise functionally 100% equivalent to source-generated avatars. Note that we don't pack avatars in ManualAvatars to avoid collisions. Since the package is installed as source, the type names of generated avatars would collide with the included "manual" avatars, so don't pack them. We are including them in the source so they can be explored in Avatar' source itself for learning/troubleshooting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.