8000 Add test from #343 to regression test suite by stakx · Pull Request #907 · devlooped/moq · GitHub
[go: up one dir, main page]

Skip to content

Add test from #343 to regression test suite - #907

Merged
stakx merged 1 commit into
devlooped:masterfrom
stakx:method-binding
Aug 25, 2019
Merged

stakx merged 1 commit into
devlooped:masterfrom
stakx:method-binding

Conversation

@stakx
@stakx stakx commented Aug 25, 2019 •
Copy link
Copy Markdown
Contributor

which demonstrates that Moq no longer cares (because of #904) about the precise return type of methods if they otherwise match. This enables some scenarios involving generic methods that previously weren't supported.

(It seems correct that Moq no longer tries to match method's return types exactly. While technically not incorrect, it is unusual behavior for most people coming from VB.NET or C#, where the return type is not
considered part of the method signature WRT method resolution.)

Closes #906.

/cc @oddbear who originally came up with that test

which demonstrates that Moq no longer cares about the precise return
type of methods if they otherwise match. This enables some scenarios
involving generic methods that previously weren't supported.

(It seems correct that Moq no longer tries to match method's return
types exactly. While technically not incorrect, it is unusual behavior
for most people coming from VB.NET or C#, where the return type is not
considered part of the method signature WRT method resolution.)
@stakx stakx added this to the 4.13.0 milestone Aug 25, 2019
@stakx
stakx merged commit 9c5209e into devlooped:master Aug 25, 2019
@stakx
stakx deleted the method-binding branch August 25, 2019 12:27
@devlooped devlooped locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New method matching algorithm introduces behavioral change wrt return types

1 participant

0