Repository navigation
Make VerifyAll ignore setups from SetupAllProperties - #684
Merged
Merged
Conversation
This adds a test demonstrating that `SetupAllProperties` as it is currently implemented makes `VerifyAll` fail. `SetupAllProperties` registers a setup for each and every property accessor, requiring the user to invoke every one of those to make `VerifyAll` pass. This ren- ders `VerifyAll` rather useless in practice.
Those property accessors that are auto-implemented by `SetupAllProper- ties` no longer need to be invoked in order to pass verification by `VerifyAll`. (This is easily implemented now that setups verify them- selves, because for auto-implemented property accessors we have two dedicated setup types.)
stakx
force-pushed
the
setupallproperties-verifyall
branch
from
September 5, 2018 18:11
4004e20 to
a262fe5
Compare
This was referenced Sep 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #681 (and fixes both #191 and #556) by making
VerifyAllignore the setups registered bySetupAllProperties.