Repository navigation
Verify that in parameter modifier is supported - #625
Conversation
|
@stakx And what about delegates with |
|
@stakx Oh, disregard - you have a test for that. That's really interesting - will investigate later how that works, given that we emit own interface... |
|
@zvirja - In Moq, think the important bits occur here: Note that in the call to I'm not actually sure the above loop is needed at all—quite possibly it does little more than copy the parameter names (and perhaps even that has already happened). |
I dont see that. You pass parameter types, but they don't carry modifiers.. I suspect that it happens because runtime allows delegate and method to differ by |
|
@zvirja - Oh boy, you're right. Now I feel like a fool. 🦆😆 The tests I've already got there might be inadequate then. I've done some more REPL-style testing, Moq indeed doesn't reproduce the delegate method's signature accurately, yet invoking the mocked delegate still works. If, during your own investigations, you find a way of making mocked delegate invocation fail, I'd love to hear what your tests look like! |
|
@zvirja - I found out why delegate mocking works even when custom modifiers aren't replicated. It seems that for delegates, the CLR performs a signature check that's less strict than usual: public delegate void WithIn(in AttributeTargets arg);
public interface WithoutIn
{
void Invoke(ref AttributeTargets arg);
}
public class Impl : WithoutIn
{
public void Invoke(ref AttributeTargets arg)
{
Console.WriteLine($"Called with {arg}.");
}
}
class Program
{
static void Main(string[] args)
{
// The following will print 1 and 0, meaning that the metho signatures differ!
Console.WriteLine(typeof(WithIn).GetMethod("Invoke").GetParameters()[0].GetRequiredCustomModifiers().Length);
Console.WriteLine(typeof(WithoutIn).GetMethod("Invoke").GetParameters()[0].GetRequiredCustomModifiers().Length);
// Despite the difference in signature, the methods are compatible when
// going through a delegate invocation:
var interfaceMethod = typeof(WithoutIn).GetMethod("Invoke");
var deleg = (WithIn)interfaceMethod.CreateDelegate(typeof(WithIn), new Impl());
deleg.Invoke(AttributeTargets.All);
}
}I might raise an issue over at dotnet/coreclr later to ask whether that's accidental or intentional, but for now I'll add custom modifier replication code to Moq. Thanks for double-checking this PR! 👍 |
|
@stakx Thanks for raising the investigation. It's indeed a critical issue, as you can now rewrite the Let's see what guys think about this. |
This adds a few tests, including those mentioned in castleproject/Core#339 (comment) and castleproject/Core#339 (comment), to document the state of
inparameter modifier support.As it turns out, the previous update of Castle.Core to 4.3.0 makes
inparameter modifiers work on .NET Core even though Moq doesn't specifically target .NET Standard 1.5 or above... it suffices that Castle.Core does that.(.NET Standard 1.3 vs 1.5 is important because the latter includes the System.Reflection.Emit facilities required for mocking
in; more specifically, the ability to emit custom modifiers.)This closes #605.