8000 fix: keep auto-refresh failures off the timer thread by malys · Pull Request #181 · deminimis/minimalfirewall · GitHub
[go: up one dir, main page]

Skip to content

fix: keep auto-refresh failures off the timer thread - #181

Open
malys wants to merge 1 commit into
deminimis:mainfrom
malys:fix/autorefresh-async-lambda
Open

malys wants to merge 1 commit into
deminimis:mainfrom
malys:fix/autorefresh-async-lambda

Conversation

@malys
@malys malys commented Nov 13, 2026
Copy link
Copy Markdown

The auto-refresh timer marshalled an async lambda through a blocking Invoke. An exception before the first await came back on the timer thread, unhandled, and terminated the process.

  • Catch and log refresh failures inside the lambda.
  • Use BeginInvoke so the timer thread does not block on the UI.
  • Catch InvalidOperationException (covers ObjectDisposedException) during shutdown.

Test: Release x64 build passes. Not reproduced manually.

🤖 Generated with Claude Code

The auto-refresh timer marshalled an async lambda with a blocking Invoke.
An exception thrown before the first await came back through Invoke onto
the thread-pool timer thread, where it is unhandled and terminates the
process; later failures surfaced as a generic erro
8000
r dialog. Catch and log
refresh failures inside the lambda, use BeginInvoke so the timer thread
is not blocked, and also ignore InvalidOperationException when the handle
is destroyed during shutdown.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0