Linter: Update implementation code #8146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e28ca9
to
537c4d8
Compare
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
Sep 26, 2024
Updates all test code to adhear to the knew linter rules. Branched from dapr#8146 to ensure that no test changes were made for that PR to test that no implementation functional changes were made. Removes rule in github workflows to only test new changes. Signed-off-by: joshvanl <me@joshvanl.dev>
Update Dapr implementation code to adhere to new linter rules. All test files have been purposefully omitted to ensure that the implementation code is still functionally correct. A follow-up commit will contain the update to all test code, and removal of the "only new changes" linted from the github linter workflow. Signed-off-by: joshvanl <me@joshvanl.dev>
537c4d8
to
c900e90
Compare
|
/ok-to-test |
|
/ok-to-perf |
Dapr E2E testCommit ref: c900e90 ✅ Infrastructure deployed
✅ Build succeeded for linux/amd64
✅ Build succeeded for windows/amd64
❌ Tests failed on linux/amd64Please check the logs for details on the error. ❌ Tests failed on windows/amd64Please check the logs for details on the error. |
Dapr perf testCommit ref: c900e90 ✅ Infrastructure deployed
✅ Build succeeded
❌ Perf tests failedPlease check the logs for details on the error. |
|
/ok-to-test |
|
/ok-to-perf |
Dapr E2E testCommit ref: c900e90 ✅ Infrastructure deployed
✅ Build succeeded for linux/amd64
✅ Build succeeded for windows/amd64
✅ Tests succeeded on windows/amd64
❌ Tests failed on linux/amd64Please check the logs for details on the error. |
Dapr perf testCommit ref: c900e90 ✅ Infrastructure deployed
✅ Build succeeded
❌ Perf tests failedPlease check the logs for details on the error. |
7 tasks
mikeee
requested changes
Oct 1, 2024
elena-kolevska
approved these changes
Oct 1, 2024
elena-kolevska
requested changes
Oct 2, 2024
There was a problem hiding this comment.
The typo shaddow made me think there could be other errors on which the tool failed silently, so I did a quick search and found out about the golangci-lint config verify command. It brought a few additional errors we need to fix. I put a few of them as suggestions, and here are two more I can't add as comments in code:
Under linter-settings:
# `check-exported: false` is not valid anymore, I suggest:
unused:
# Mark all exported fields as used.
exported-fields-are-used: false
# We used to have `allow-case-traling-whitespace: true` which is not allowed anymore. We can either delete the config completely, or force a new line as so:
wsl:
...
# If the number of lines in a case block is equal to or lager than this number,
# the case *must* end white a newline.
# https://github.com/bombsimon/wsl/blob/master/doc/configuration.md#force-case-trailing-whitespace
# Default: 0
force-case-trailing-whitespace: 1
Signed-off-by: joshvanl <me@joshvanl.dev>
|
Thanks @elena-kolevska @mikeee, please take another look! |
elena-kolevska
approved these changes
Oct 2, 2024
cicoyle
approved these changes
Oct 2, 2024
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
Oct 2, 2024
Updates all test code to adhear to the knew linter rules. Branched from dapr#8146 to ensure that no test changes were made for that PR to test that no implementation functional changes were made. Removes rule in github workflows to only test new changes. Signed-off-by: joshvanl <me@joshvanl.dev>
artursouza
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Linter: Updates test code for new linter rules Updates all test code to adhear to the knew linter rules. Branched from #8146 to ensure that no test changes were made for that PR to test that no implementation functional changes were made. Removes rule in github workflows to only test new changes. Signed-off-by: joshvanl <me@joshvanl.dev> * Review comments Signed-off-by: joshvanl <me@joshvanl.dev> * Fix app pubsub string Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
Oct 3, 2024
* Linter: Updates test code for new linter rules Updates all test code to adhear to the knew linter rules. Branched from dapr#8146 to ensure that no test changes were made for that PR to test that no implementation functional changes were made. Removes rule in github workflows to only test new changes. Signed-off-by: joshvanl <me@joshvanl.dev> * Review comments Signed-off-by: joshvanl <me@joshvanl.dev> * Fix app pubsub string Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Dapr implementation code to adhere to new linter rules. All test files have been purposefully omitted to ensure that the implementation code is still functionally correct. A follow-up commit will contain the update to all test code, and removal of the "only new changes linted" from the github linter workflow.